Add multi chain for the rest of the hmc nuts samplers#3212
Merged
Add multi chain for the rest of the hmc nuts samplers#3212
Conversation
WardBrian
approved these changes
Jul 25, 2023
Member
WardBrian
left a comment
WardBrian
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for doing this! CmdStan can get a lot cleaner for most cases.
As an aside: how difficult would it be to allow the num_chains argument for the fixed_param sampler? Since we currently sometimes select it by default (stan-dev/cmdstan#1029) it's an annoying edge case for num_chains
WardBrian
requested changes
Jul 25, 2023
WardBrian
approved these changes
Jul 26, 2023
2 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py src/test/unitmake cpplintSummary
Issue #3204
This adds multi chain service functions for hmc nuts for adapatation and nonadaption for the unit e, diag, and dense metrics.
Intended Effect
Allow users of the service layer to use tbb multithreading to spin up multiple chains via the service layer
How to Verify
Tests added to show usage
Side Effects
Documentation
New docs added for each function
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Steve Bronder
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: