Service functions: Consistent exception handling and error logging#3214
Merged
Service functions: Consistent exception handling and error logging#3214
Conversation
2 tasks
SteveBronder
approved these changes
Jul 26, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py src/test/unitmake cpplintSummary
Currently, the services functions are inconsistent on whether or not they will throw an exception. The versions which accept
num_chainsshould never throw, but the older ones will throw if initialization fails.This consistently puts
utils::initializein atryblock.Additionally, we are currently using
logger.infofor messages which are errors, and in several places not logging an error where we could (e.g., thecatchblocks accompanying the abovetrys).Intended Effect
Improved error logging and exception safety in the services functions
How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: