The closing body tag has been moved right before the closing html tag#511
Merged
joseluisq merged 2 commits intostatic-web-server:masterfrom Dec 10, 2024
Merged
The closing body tag has been moved right before the closing html tag#511joseluisq merged 2 commits intostatic-web-server:masterfrom
joseluisq merged 2 commits intostatic-web-server:masterfrom
Conversation
|
Review changes with |
joseluisq
requested changes
Dec 10, 2024
Collaborator
joseluisq
left a comment
joseluisq
left a comment
There was a problem hiding this comment.
Good catch! Please just resolve the minor formatting suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was a mistake in the html hierarhy: the body contained only h1 tag.
Description
I moved closing body tag right before closing html tag.
Related Issue
It is too obvious to create an issue.
Motivation and Context
Compliance with HTML specification.
How Has This Been Tested?
I checked source code of directory listing returned by fixed static-web-server using https://validator.w3.org/nu/#textarea