[SYS-252] listassetallocationtransactions#254
Merged
evscott merged 1 commit intodev-3.x-prep-3.0.7from Aug 7, 2018
Merged
Conversation
Fixed an issue with default count always being used when calling listassetallocationtransactions.
evscott
changed the title
Member
|
NACK can you take a look at my commit, this wouldn't have fixed the problem for the case where you have more than one tx per block. You need the internal and external loop break. Please retest that it works as expected with my fix above in 780cf7a |
Member
|
Why did you commit this @evscott there was problems with this which ive already fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue with default count always being used when calling listassetallocationtransactions.
When using the syscoin-cli command listassetallocationtransactions, the system should return the number of transactions up to matching the first argument passed into the command, with the default being 10 if no argument is passed.
Formating e.g.:
listassetallocationtransactions
This should return up to 10 transactions
list assetallocationtransactions
This should return up to 2 transactions