Skip to content

Fix commits from #13246#13365

Merged
keszybz merged 4 commits intosystemd:masterfrom
keszybz:fix-commits-from-pr-13246
Aug 22, 2019
Merged

Fix commits from #13246#13365
keszybz merged 4 commits intosystemd:masterfrom
keszybz:fix-commits-from-pr-13246

Conversation

@keszybz
Copy link
Member

@keszybz keszybz commented Aug 20, 2019

No description provided.

Ubuntu autopkgtests print output from all tests, and test-event produces
a lot of it. Let's cut it down to reasonable size.
Ubunut autopkgtest fails with:
405/501 test-journal-flush                      FAIL     0.74 s (killed by signal 6 SIGABRT)

--- command ---
SYSTEMD_KBD_MODEL_MAP='/tmp/autopkgtest.BgjJJv/build.yAM/systemd/src/locale/kbd-model-map' SYSTEMD_LANGUAGE_FALLBACK_MAP='/tmp/autopkgtest.BgjJJv/build.yAM/systemd/src/locale/language-fallback-map' PATH='/tmp/autopkgtest.BgjJJv/build.yAM/systemd/build-deb:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games' /tmp/autopkgtest.BgjJJv/build.yAM/systemd/build-deb/test-journal-flush
--- stderr ---
Assertion 'r >= 0' failed at src/journal/test-journal-flush.c:48, function main(). Aborting.
-------

It's hard to say what is going on here without any error messages whatsoever.
The test goes into deep details of journal file handling, so it needs to also
do logging on its own.
We must be all lazy, at least I know I always used -p ;).
@keszybz keszybz added this to the v243 milestone Aug 20, 2019
@poettering poettering added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Aug 20, 2019
@keszybz
Copy link
Member Author

keszybz commented Aug 20, 2019

CentosCI (arch in kvm) failed with

--- stderr ---
journal_file_copy_entry failed: Bad message
Assertion 'r >= 0' failed at src/journal/test-journal-flush.c:52, function main(). Aborting.

So I think that's the commit working as expected. At least we know the error code.

@keszybz keszybz merged commit d0696f3 into systemd:master Aug 22, 2019
@keszybz keszybz deleted the fix-commits-from-pr-13246 branch August 22, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed

Development

Successfully merging this pull request may close these issues.

2 participants