LDAP: Allow TLS certificate checking policy to be configured#180
Merged
tchapi merged 1 commit intotchapi:mainfrom Feb 19, 2025
Merged
LDAP: Allow TLS certificate checking policy to be configured#180tchapi merged 1 commit intotchapi:mainfrom
tchapi merged 1 commit intotchapi:mainfrom
Conversation
Owner
|
Hi @daedric and thanks for your contribution! I'm not a LDAP expert, but it seems overall correct
Thank you again! |
Contributor
Author
I don't mind, the reason for this naming that the usual config/env variable for that is I really don't mind changing it, as I find it clearer too. Please let me know.
Will do!
My pleasure! |
Owner
Yes, I'd change it personally 🙏🏼 Thanks |
daedric
force-pushed
the
ts/chore/tls-check
branch
3 times, most recently
from
dead85c to
41c427c
Compare
daedric
force-pushed
the
ts/chore/tls-check
branch
from
41c427c to
dad99f9
Compare
Contributor
Author
|
FYI I've done the requested changed :) |
Owner
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of a local LDAP server, certificates do not always match the address.
In this case, we cannot connect to the LDAP server.
This PR allows one to configure a policy for certificate checking.
PHP is not my forte, please do not hesitate if anything is not idiomatic nor good :)