Skip to content

Includes visual guide representing chains config options#1183

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
anithapriyanatarajan:enrich-config-doc
Aug 22, 2024
Merged

Includes visual guide representing chains config options#1183
tekton-robot merged 1 commit intotektoncd:mainfrom
anithapriyanatarajan:enrich-config-doc

Conversation

@anithapriyanatarajan
Copy link
Contributor

@anithapriyanatarajan anithapriyanatarajan commented Aug 22, 2024

Changes

Includes visual guide representing chains config options

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2024
@tekton-robot
Copy link

tekton-robot commented Aug 22, 2024

Hi @anithapriyanatarajan. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PuneetPunamiya
Copy link
Member

PuneetPunamiya commented Aug 22, 2024

Thanks for the pr 🙂
This would really help the users I think

LGTM

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2024
@PuneetPunamiya
Copy link
Member

PuneetPunamiya commented Aug 22, 2024

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2024
@anithapriyanatarajan
Copy link
Contributor Author

anithapriyanatarajan commented Aug 22, 2024

Thanks for the pr 🙂 This would really help the users I think

LGTM

@PuneetPunamiya Thankyou. As you have highlighted the drawio.svg allows for future edit.

@anithapriyanatarajan
Copy link
Contributor Author

anithapriyanatarajan commented Aug 22, 2024

/test pull-tekton-chains-integration-tests

lcarva
lcarva approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is great! Thank you so much ❤️

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@tekton-robot
Copy link

tekton-robot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2024
@tekton-robot tekton-robot merged commit 821f7c4 into tektoncd:main Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcarva lcarva lcarva approved these changes

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

Assignees

@lcarva lcarva

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anithapriyanatarajan @tekton-robot @PuneetPunamiya @lcarva