Support mongo server url path by PuneetPunamiya · Pull Request #1213 · tektoncd/chains

PuneetPunamiya · 2024-09-24T09:35:35Z

Previously when storage.docdb.mongo-server-url-dir was set, then value was read from the path specified in the field plus MONGO_SERVER_URL i.e. (for e.g. /mnt/mongo-creds-secret/MONGO_SERVER_URL) so user had to create the secret with the key MONGO_SERVER_URL
Hence, with this patch user can specify the path now and the tokwn will be read from the path specified

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2024-09-24T09:40:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/docdb/docdb.go	73.6%	64.2%	-9.3

PuneetPunamiya · 2024-09-24T11:10:27Z

/test pull-tekton-chains-unit-tests

tekton-robot · 2024-09-24T11:11:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/docdb/docdb.go	73.6%	54.1%	-19.4

pkg/chains/storage/docdb/docdb.go

docs/config.md

pkg/chains/storage/docdb/docdb.go

docs/config.md

pkg/chains/storage/docdb/docdb.go

tekton-robot · 2024-09-25T11:27:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/docdb/docdb.go	73.6%	64.3%	-9.3

tekton-robot · 2024-09-25T13:05:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/docdb/docdb.go	73.6%	64.3%	-9.3

tekton-robot · 2024-09-25T13:30:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/docdb/docdb.go	73.6%	64.3%	-9.3

tekton-robot · 2024-09-26T07:20:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/docdb/docdb.go	73.6%	64.3%	-9.3

docs/config.md

pkg/chains/storage/docdb/docdb.go

tekton-robot · 2024-10-04T07:17:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/docdb/docdb.go	73.6%	64.6%	-9.0

PuneetPunamiya · 2024-10-04T07:43:02Z

/test pull-tekton-chains-integration-tests

docs/config.md

Previously when `storage.docdb.mongo-server-url-dir` was set, then value was read from the path specified in the field plus `MONGO_SERVER_URL` i.e. (for e.g. /mnt/mongo-creds-secret/MONGO_SERVER_URL) so user had to create the secret with the key `MONGO_SERVER_URL` Hence, with this patch user can specify the path now and the tokwn will be read from the path specified Signed-off-by: PuneetPunamiya <[email protected]>

tekton-robot · 2024-10-10T05:53:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/storage/docdb/docdb.go	48.8%	41.8%	-7.0

lcarva

/lgtm

tekton-robot · 2024-10-10T13:20:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil, lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lcarva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2024

tekton-robot requested review from lcarva and wlynch September 24, 2024 09:35

PuneetPunamiya force-pushed the fix-mongo-config branch 2 times, most recently from c6d30fd to 1615c58 Compare September 24, 2024 10:55

jkhelil reviewed Sep 24, 2024

View reviewed changes

pkg/chains/storage/docdb/docdb.go Outdated Show resolved Hide resolved

pkg/chains/storage/docdb/docdb.go Show resolved Hide resolved

pkg/chains/storage/docdb/docdb.go Show resolved Hide resolved

docs/config.md Outdated Show resolved Hide resolved

savitaashture reviewed Sep 24, 2024

View reviewed changes

PuneetPunamiya force-pushed the fix-mongo-config branch from 1615c58 to 32717ef Compare September 25, 2024 11:22

PuneetPunamiya force-pushed the fix-mongo-config branch from 32717ef to 72dd844 Compare September 25, 2024 13:00

PuneetPunamiya force-pushed the fix-mongo-config branch from 72dd844 to d59a681 Compare September 25, 2024 13:25

PuneetPunamiya force-pushed the fix-mongo-config branch from d59a681 to 713cf03 Compare September 26, 2024 07:14

jkhelil approved these changes Sep 26, 2024

View reviewed changes

lcarva reviewed Sep 27, 2024

View reviewed changes

PuneetPunamiya force-pushed the fix-mongo-config branch from 713cf03 to 4cad9b9 Compare October 4, 2024 07:11

lcarva reviewed Oct 10, 2024

View reviewed changes

docs/config.md Outdated Show resolved Hide resolved

PuneetPunamiya force-pushed the fix-mongo-config branch from 4cad9b9 to cd6eae2 Compare October 10, 2024 05:47

lcarva approved these changes Oct 10, 2024

View reviewed changes

tekton-robot assigned lcarva Oct 10, 2024

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024

tekton-robot merged commit 69a8f5f into tektoncd:main Oct 10, 2024

Conversation

PuneetPunamiya commented Sep 24, 2024

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Sep 24, 2024

Uh oh!

PuneetPunamiya commented Sep 24, 2024

Uh oh!

tekton-robot commented Sep 24, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Sep 25, 2024

Uh oh!

tekton-robot commented Sep 25, 2024

Uh oh!

tekton-robot commented Sep 25, 2024

Uh oh!

tekton-robot commented Sep 26, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Oct 4, 2024

Uh oh!

PuneetPunamiya commented Oct 4, 2024

Uh oh!

Uh oh!

tekton-robot commented Oct 10, 2024

Uh oh!

lcarva left a comment

Choose a reason for hiding this comment

Uh oh!

tekton-robot commented Oct 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants