Skip to content

fix nil pointer#1248

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
jkhelil:fix_nil_pointer
Nov 12, 2024
Merged

fix nil pointer#1248
tekton-robot merged 1 commit intotektoncd:mainfrom
jkhelil:fix_nil_pointer

Conversation

@jkhelil
Copy link
Member

@jkhelil jkhelil commented Nov 12, 2024

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2024
vdemeester
vdemeester approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @lcarva
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@vdemeester
Copy link
Member

vdemeester commented Nov 12, 2024

/cherry-pick release-v0.23.x

@tekton-robot
Copy link

tekton-robot commented Nov 12, 2024

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.23.x in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v0.23.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lcarva
lcarva approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

tekton-robot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@lcarva
Copy link
Contributor

lcarva commented Nov 12, 2024

/retest

3 similar comments
@jkhelil
Copy link
Member Author

jkhelil commented Nov 12, 2024

/retest

@jkhelil
Copy link
Member Author

jkhelil commented Nov 12, 2024

/retest

@vdemeester
Copy link
Member

vdemeester commented Nov 12, 2024

/retest

@vdemeester vdemeester closed this Nov 12, 2024
@vdemeester vdemeester reopened this Nov 12, 2024
@tekton-robot
Copy link

tekton-robot commented Nov 12, 2024

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 75.9% 74.4% -1.4

@tekton-robot tekton-robot merged commit 287373e into tektoncd:main Nov 12, 2024
@tekton-robot
Copy link

tekton-robot commented Nov 12, 2024

@vdemeester: new pull request created: #1249

Details

In response to this:

/cherry-pick release-v0.23.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Nov 12, 2024
Merged
@jkhelil
Copy link
Member Author

jkhelil commented Jan 16, 2025

/cherry-pick release-v0.22.x

@tekton-robot
Copy link

tekton-robot commented Jan 16, 2025

@jkhelil: new pull request created: #1283

Details

In response to this:

/cherry-pick release-v0.22.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@lcarva lcarva lcarva approved these changes

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@vdemeester vdemeester

@lcarva lcarva

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkhelil @vdemeester @tekton-robot @lcarva