Skip to content

Remove ttl.sh dependency for microshift gh action#1396

Merged
tekton-robot merged 2 commits intotektoncd:mainfrom
khrm:localRepo
Jul 7, 2025
Merged

Remove ttl.sh dependency for microshift gh action#1396
tekton-robot merged 2 commits intotektoncd:mainfrom
khrm:localRepo

Conversation

@khrm
Copy link
Contributor

@khrm khrm commented Jul 4, 2025

Remove the ttl.sh dependency and instead use podman.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 4, 2025
@khrm khrm force-pushed the localRepo branch 2 times, most recently from 24b0ad8 to e4f5b7a Compare July 4, 2025 10:31
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2025
@khrm
Copy link
Contributor Author

khrm commented Jul 4, 2025

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 4, 2025
@khrm khrm force-pushed the localRepo branch 7 times, most recently from 378d2b5 to 8bbcde1 Compare July 4, 2025 11:31
@khrm
Copy link
Contributor Author

khrm commented Jul 4, 2025

/hold
Let's wait for e2e tests result.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025
Remove the ttl.sh dependency and instead use podman's service.
Also, remove the irrelevant code and change the name of
test runner file to test_microshift.sh
@khrm
Copy link
Contributor Author

khrm commented Jul 4, 2025

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025
@khrm
Copy link
Contributor Author

khrm commented Jul 4, 2025

Since we can verify that all tests pass. I should put this to push only.

Microshift GH action should be only on push/merges.
@khrm
Copy link
Contributor Author

khrm commented Jul 4, 2025

/assign @PuneetPunamiya

Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@tekton-robot tekton-robot merged commit 26f8978 into tektoncd:main Jul 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants