Conversation
tekton-robot
added
the
size/M
jkhelil
force-pushed
the
fix_e2e_spire
branch
3 times, most recently
from
3a594b9 to
ad9661d
Compare
test/testdata/spire.yaml
Outdated
| # you prefer that waits for a service to be up. This image is built | ||
| # from https://github.com/lqhl/wait-for-it | ||
| image: gcr.io/spiffe-io/wait-for-it | ||
| image: quay.io/jkhelil/wait-for-it |
There was a problem hiding this comment.
hmm could we use a non-personal image here?
There was a problem hiding this comment.
We could have it on plumbing and pushed there.
cc @afrittoli
There was a problem hiding this comment.
I'm ok with accepting these changes for now, especially if other tektoncd project have already done so. Can someone confirm that's the case?
There was a problem hiding this comment.
➜ crane cp quay.io/jkhelil/wait-for-it ghcr.io/tektoncd/plumbing/wait-for-it
2025/10/08 16:47:04 Copying from quay.io/jkhelil/wait-for-it to ghcr.io/tektoncd/plumbing/wait-for-it
2025/10/08 16:47:10 pushed blob: sha256:7965d6fd3ddfaeca3d84ab6ff634d399fc7bed455afb2501d0c1d8ff6d483b81
2025/10/08 16:47:11 pushed blob: sha256:1e5367194cc84d80c04f25e35203593ba9a14baee0d5079264c0e50b98fc241c
2025/10/08 16:47:12 pushed blob: sha256:a0d0a0d46f8b52473982a3c466318f479767577551a53ffc9074c9fa7035982e
2025/10/08 16:47:15 pushed blob: sha256:f98b5ba86c6c6b544eea031bd3d853d84ce7701c82783520748beb10dfa1abce
2025/10/08 16:47:16 pushed blob: sha256:a36bb3d8db67b1d88c13cdd33128e1989c2da9cd6c23c54a7324337dfd32eb42
2025/10/08 16:47:17 pushed blob: sha256:ae2d64a5f3efe5bcf0672fa553a507c8119905daddcce544601da06d9664f553
2025/10/08 16:47:17 ghcr.io/tektoncd/plumbing/wait-for-it: digest: sha256:3facff26e582e57e3b994d3a3b95fc06475bb02a3dc6647ce6c91f4c3c2534b5 size: 1362
The image is copied, if you want to use I can make it public.
We don't have a workflow to rebuild it though, at least for now. If you wanted one, we already have a number of images we build from the plumbing repo, so we could build one more.
There was a problem hiding this comment.
I am not sure it is worth building this, there is a comment in the current code with
# This is a small image with wait-for-it, choose whatever image
# you prefer that waits for a service to be up. This image is built
# from https://github.com/lqhl/wait-for-it
I just copied the current one to my personal repo, now it is in plumbing, i think making it public is enough for now I have updated the change with plumbing image
@afrittoli can you make it public please
|
/retest |
jkhelil
force-pushed
the
fix_e2e_spire
branch
from
7abba72 to
fa74091
Compare
|
@lcarva can you approve please |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
5 participants
Changes
This PR fixes gcr image pulling failure, gcr is deprecated. In this change we use images lates from ghcr for spire-agent and spire-server
wait-for-it utility image is copied to pulmbing packages
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes