Skip to content

Manually bump in-toto-golang to v0.8.0#795

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
chitrangpatel:update-intoto-golang-0.8
May 8, 2023
Merged

Manually bump in-toto-golang to v0.8.0#795
tekton-robot merged 1 commit intotektoncd:mainfrom
chitrangpatel:update-intoto-golang-0.8

Conversation

@chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented May 4, 2023 •
edited
Loading

in-toto-golang introduced support for SLSA1.0 predicate in v0.8.0 This PR manually bumps in-toto-golang to v0.8.0.
This PR partly addresses issue #728.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot requested review from chuangw6 and lcarva May 4, 2023 16:55
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 4, 2023
@chitrangpatel chitrangpatel changed the title Upgrade in-toto-golang to v0.8.0 Manually Bump in-toto-golang to v0.8.0 May 4, 2023
@chitrangpatel chitrangpatel changed the title Manually Bump in-toto-golang to v0.8.0 Manually bump in-toto-golang to v0.8.0 May 4, 2023
chuangw6
chuangw6 reviewed May 4, 2023
View reviewed changes
@chitrangpatel chitrangpatel force-pushed the update-intoto-golang-0.8 branch from 3de95dd to d2da5b9 Compare May 4, 2023 17:11
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 4, 2023
@chuangw6
Copy link
Member

chuangw6 commented May 4, 2023

/approve

@tekton-robot
Copy link

tekton-robot commented May 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuangw6

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@chitrangpatel chitrangpatel marked this pull request as draft May 4, 2023 17:37
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2023
@chitrangpatel chitrangpatel force-pushed the update-intoto-golang-0.8 branch from d2da5b9 to 1403706 Compare May 4, 2023 17:55
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 4, 2023
@chitrangpatel chitrangpatel marked this pull request as ready for review May 4, 2023 17:56
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2023
@wlynch
Copy link
Member

wlynch commented May 4, 2023

third_party directory is causing trouble - we removed this awhile back, but looks like it was never removed from hack/update_deps.sh. #796 to fix.

@wlynch wlynch requested review from wlynch and removed request for lcarva and priyawadhwa May 4, 2023 20:39
@wlynch
Copy link
Member

wlynch commented May 4, 2023

For now you can just rm -rf third_party and this PR should be good to go.

@chitrangpatel
Upgrade in-toto-golang to v0.8.0
3a8ce5c 
`in-toto-golang` introduced support for SLSA1.0 predicate in v0.8.0
This PR manually bumps `in-toto-golang` to v0.8.0.
@chitrangpatel chitrangpatel force-pushed the update-intoto-golang-0.8 branch from 1403706 to 3a8ce5c Compare May 4, 2023 22:54
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 4, 2023
@chitrangpatel
Copy link
Contributor Author

chitrangpatel commented May 4, 2023

For now you can just rm -rf third_party and this PR should be good to go.

Thanks! Done.

@chitrangpatel
Copy link
Contributor Author

chitrangpatel commented May 5, 2023

ping for a quick review @wlynch 🙏 Thanks!

@chuangw6
Copy link
Member

chuangw6 commented May 8, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@chitrangpatel chitrangpatel mentioned this pull request May 8, 2023
Closed
7 tasks
@tekton-robot tekton-robot merged commit 37baf18 into tektoncd:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chuangw6 chuangw6 Awaiting requested review from chuangw6

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@chuangw6 chuangw6

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chitrangpatel @chuangw6 @tekton-robot @wlynch