Slsa1.0 params, builderID, buildType, subjects, metadata, byProducts by chitrangpatel · Pull Request #800 · tektoncd/chains

chitrangpatel · 2023-05-09T18:17:24Z

Changes

This PR adds support for adding external and internal parameters, builder information and run details like build metadata to the slsa 1.0 predicate for pipelineruns and taskruns. This is a follow up to PR #798.

The next PR will wire everything up and implement e2e tests and docs.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add external and internal parameters, builderID, buildType, subjects, metadata and byProducts to slsa1.0 predicate.

/kind feature

tekton-robot · 2023-05-09T18:21:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	74.1%	69.1%	-5.0
pkg/chains/formats/slsa/internal/material/material.go	84.1%	84.8%	0.7
pkg/chains/formats/slsa/v2alpha2/internal/resolved_dependencies/resolved_dependencies.go	Do not exist	81.1%
pkg/chains/formats/slsa/v2alpha2/pipelinerun/pipelinerun.go	Do not exist	71.0%
pkg/chains/formats/slsa/v2alpha2/taskrun/taskrun.go	Do not exist	71.9%

chitrangpatel · 2023-05-09T18:30:19Z

/hold wait for #798 to be merged first

tekton-robot · 2023-05-09T20:18:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	74.1%	74.7%	0.6
pkg/chains/formats/slsa/internal/material/material.go	84.1%	84.8%	0.7
pkg/chains/formats/slsa/v2alpha2/internal/resolved_dependencies/resolved_dependencies.go	Do not exist	80.9%
pkg/chains/formats/slsa/v2alpha2/pipelinerun/pipelinerun.go	Do not exist	71.0%
pkg/chains/formats/slsa/v2alpha2/slsav2.go	Do not exist	87.5%
pkg/chains/formats/slsa/v2alpha2/taskrun/taskrun.go	Do not exist	71.9%

tekton-robot · 2023-05-10T15:46:27Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	74.1%	74.7%	0.6
pkg/chains/formats/slsa/internal/material/material.go	84.1%	84.8%	0.7
pkg/chains/formats/slsa/v2alpha2/internal/resolved_dependencies/resolved_dependencies.go	Do not exist	80.9%
pkg/chains/formats/slsa/v2alpha2/pipelinerun/pipelinerun.go	Do not exist	71.0%
pkg/chains/formats/slsa/v2alpha2/slsav2.go	Do not exist	87.5%
pkg/chains/formats/slsa/v2alpha2/taskrun/taskrun.go	Do not exist	71.9%

tekton-robot · 2023-05-18T19:43:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/signable.go	74.1%	73.8%	-0.3
pkg/chains/formats/slsa/internal/material/material.go	84.3%	95.9%	11.7
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go	77.2%	79.6%	2.4
pkg/chains/formats/slsa/v2alpha2/internal/resolved_dependencies/resolved_dependencies.go	Do not exist	86.8%
pkg/chains/formats/slsa/v2alpha2/pipelinerun/pipelinerun.go	Do not exist	71.0%
pkg/chains/formats/slsa/v2alpha2/slsav2.go	Do not exist	87.5%
pkg/chains/formats/slsa/v2alpha2/taskrun/taskrun.go	Do not exist	71.9%

chitrangpatel · 2023-05-24T14:04:41Z

/hold cancel

tekton-robot · 2023-05-24T14:08:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/slsa/v2alpha2/pipelinerun/pipelinerun.go	Do not exist	71.0%
pkg/chains/formats/slsa/v2alpha2/slsav2.go	Do not exist	87.5%
pkg/chains/formats/slsa/v2alpha2/taskrun/taskrun.go	Do not exist	71.9%

tekton-robot · 2023-05-24T14:34:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go	Do not exist	90.3%
pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go	Do not exist	90.6%
pkg/chains/formats/slsa/v2alpha2/slsav2.go	Do not exist	87.5%

chuangw6 · 2023-05-25T18:09:11Z

/assign

chuangw6

Thank you @chitrangpatel for implementing this!!!

pkg/chains/formats/slsa/v2alpha2/slsav2.go

pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun_test.go

pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go

pkg/chains/formats/slsa/v2alpha2/slsav2_test.go

pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun_test.go

chitrangpatel · 2023-05-30T15:06:05Z

@chuangw6 thanks for your comments! I've addressed them all now.

tekton-robot · 2023-05-30T15:12:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go	Do not exist	90.3%
pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go	Do not exist	90.3%
pkg/chains/formats/slsa/v2alpha2/slsav2.go	Do not exist	87.5%

pkg/chains/formats/format.go

pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go

pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go

This PR adds support for adding external and internal parameters, builder information and run details like build metadata to the slsa 1.0 predicate for pipelineruns and taskruns.

tekton-robot · 2023-06-01T19:29:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go	Do not exist	90.3%
pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go	Do not exist	90.3%
pkg/chains/formats/slsa/v2alpha2/slsav2.go	Do not exist	87.5%

lcarva

/lgtm

Thank you! 🎉

tekton-robot · 2023-06-01T20:16:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lcarva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chuangw6 · 2023-06-01T21:08:19Z

LGTM too! Thanks @chitrangpatel !!

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 9, 2023

tekton-robot requested review from lcarva and priyawadhwa May 9, 2023 18:17

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 9, 2023

chitrangpatel marked this pull request as draft May 9, 2023 18:18

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2023

chitrangpatel changed the title ~~Slsa1.0 params builder subjects metadata~~ Slsa1.0 params, builderID, buildType, subjects, metadata, byProducts May 9, 2023

chitrangpatel mentioned this pull request May 9, 2023

Implementation of SLSA v1.0 predicate in Chains #797

Closed

7 tasks

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023

chitrangpatel force-pushed the SLSA1.0-paramsBuilderSubjectsMetadata branch 4 times, most recently from a070ede to 70e01fc Compare May 9, 2023 20:12

chitrangpatel marked this pull request as ready for review May 9, 2023 20:13

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2023

tekton-robot requested a review from chuangw6 May 9, 2023 20:14

chitrangpatel force-pushed the SLSA1.0-paramsBuilderSubjectsMetadata branch from 70e01fc to 1aeb1d8 Compare May 10, 2023 15:40

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2023

chitrangpatel force-pushed the SLSA1.0-paramsBuilderSubjectsMetadata branch from 1aeb1d8 to 991c6db Compare May 18, 2023 19:37

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2023

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023

chitrangpatel force-pushed the SLSA1.0-paramsBuilderSubjectsMetadata branch from 991c6db to f7a9a72 Compare May 24, 2023 14:04

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2023

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023

chitrangpatel force-pushed the SLSA1.0-paramsBuilderSubjectsMetadata branch 2 times, most recently from f92a78f to 716ed5d Compare May 24, 2023 14:30

tekton-robot assigned chuangw6 May 25, 2023

chuangw6 reviewed May 29, 2023

View reviewed changes

chitrangpatel force-pushed the SLSA1.0-paramsBuilderSubjectsMetadata branch from 716ed5d to 5cd6a9a Compare May 30, 2023 15:05

chitrangpatel requested a review from chuangw6 May 30, 2023 15:05

lcarva reviewed Jun 1, 2023

View reviewed changes

slsa1.0 parameters, builder and rundetails

a4a7e9f

This PR adds support for adding external and internal parameters, builder information and run details like build metadata to the slsa 1.0 predicate for pipelineruns and taskruns.

chitrangpatel force-pushed the SLSA1.0-paramsBuilderSubjectsMetadata branch from 5cd6a9a to a4a7e9f Compare June 1, 2023 19:25

lcarva approved these changes Jun 1, 2023

View reviewed changes

tekton-robot assigned lcarva Jun 1, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023

tekton-robot merged commit 7a786de into tektoncd:main Jun 1, 2023

Conversation

chitrangpatel commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented May 9, 2023

Uh oh!

chitrangpatel commented May 9, 2023

Uh oh!

tekton-robot commented May 9, 2023

Uh oh!

tekton-robot commented May 10, 2023

Uh oh!

tekton-robot commented May 18, 2023

Uh oh!

chitrangpatel commented May 24, 2023

Uh oh!

tekton-robot commented May 24, 2023

Uh oh!

tekton-robot commented May 24, 2023

Uh oh!

chuangw6 commented May 25, 2023

Uh oh!

chuangw6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chitrangpatel commented May 30, 2023

Uh oh!

tekton-robot commented May 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Jun 1, 2023

Uh oh!

lcarva left a comment

Choose a reason for hiding this comment

Uh oh!

tekton-robot commented Jun 1, 2023

Uh oh!

chuangw6 commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chitrangpatel commented May 9, 2023 •

edited

Loading