Do not print twice Cancelled when listing#2438
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Nov 29, 2024
Merged
Conversation
When listing the status of pipelinerun we would show something like this for cancelled PR: ```console NAME STARTED DURATION STATUS pr-hmth-fmknk 5 minutes ago 1m8s Succeeded pr-hmth-7qzlb 5 minutes ago 11s Cancelled(Cancelled) pr-hmth-dtdrh 7 minutes ago 1m14s Succeeded pr-zrbj-f4kq8 7 minutes ago 1m24s Succeeded pr-zrbj-hxhw2 7 minutes ago 9s Cancelled(Cancelled) ``` which makes no sense, the Cancelled(Cancelled) is redundant, so we fix this by checking the reasons is not the same as what we are going to set. which now show a nicer: ```console NAME STARTED DURATION STATUS pr-hmth-fmknk 8 minutes ago 1m8s Succeeded pr-hmth-7qzlb 8 minutes ago 11s Cancelled pr-hmth-dtdrh 10 minutes ago 1m14s Succeeded pr-zrbj-f4kq8 10 minutes ago 1m24s Succeeded pr-zrbj-hxhw2 10 minutes ago 9s Cancelled ``` Signed-off-by: Chmouel Boudjnah <[email protected]>
tekton-robot
added
the
release-note
tekton-robot
added
size/S
Contributor
|
/lgtm |
Contributor
|
@pratap0007: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When listing the status of pipelinerun we would show something like this for cancelled PR:
which makes no sense, the Cancelled(Cancelled) is redundant, so we fix this by checking the reasons is not the same as what we are going to set. which now show a nicer:
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes