Skip to content

Add pratap0007 and divyansh42 as reviewer#2439

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
pratap0007:add-reviewer
Jan 3, 2025
Merged

Add pratap0007 and divyansh42 as reviewer#2439
tekton-robot merged 1 commit intotektoncd:mainfrom
pratap0007:add-reviewer

Conversation

@pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Nov 29, 2024

Changes

Adds @pratap0007 and @divyansh42 as reviewer

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 29, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2024
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@pratap0007
Copy link
Contributor Author

/test pull-tekton-cli-integration-tests

2 similar comments
@divyansh42
Copy link
Member

/test pull-tekton-cli-integration-tests

@vinamra28
Copy link
Member

/test pull-tekton-cli-integration-tests

@vdemeester
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit 99c273b into tektoncd:main Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants