Skip to content

Add buffer for pod event#2468

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
icloudnote:pod-log
Feb 5, 2025
Merged

Add buffer for pod event#2468
tekton-robot merged 1 commit intotektoncd:mainfrom
icloudnote:pod-log

Conversation

@icloudnote
Copy link
Contributor

@icloudnote icloudnote commented Jan 14, 2025

Changes

Fix the failure of channel closure caused by multiple events generated by the cluster in extreme cases.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2025
@tekton-robot
Copy link
Contributor

tekton-robot commented Jan 14, 2025

Hi @icloudnote. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2025
@pratap0007
Copy link
Contributor

pratap0007 commented Jan 15, 2025

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2025
@icloudnote
Copy link
Contributor Author

icloudnote commented Jan 17, 2025

/retest

@icloudnote
Copy link
Contributor Author

icloudnote commented Jan 21, 2025

/test pull-tekton-cli-integration-tests

@piyush-garg
Copy link
Contributor

piyush-garg commented Jan 27, 2025

/retest

vinamra28
vinamra28 reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@piyush-garg
Copy link
Contributor

piyush-garg commented Feb 5, 2025

/approve

@tekton-robot
Copy link
Contributor

tekton-robot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@divyansh42
Copy link
Member

divyansh42 commented Feb 5, 2025

/retest

@tekton-robot tekton-robot merged commit a68915a into tektoncd:main Feb 5, 2025
7 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@divyansh42 divyansh42 Awaiting requested review from divyansh42

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@icloudnote @tekton-robot @pratap0007 @piyush-garg @divyansh42 @vinamra28