Skip to content

Remove create clusterrole in triggers test#2471

Merged
tekton-robot merged 2 commits intotektoncd:mainfrom
piyush-garg:fix_e2e
Jan 25, 2025
Merged

Remove create clusterrole in triggers test#2471
tekton-robot merged 2 commits intotektoncd:mainfrom
piyush-garg:fix_e2e

Conversation

@piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Jan 15, 2025

This will remove creating clusterrole in triggers test as it is shipped by triggers now and an be used in clusterolebinding

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Remove create clusterrole in triggers test

@piyush-garg
Remove create clusterrole in triggers test
d3b8050 
This will remove creating clusterrole in triggers test
as it is shipped by triggers now and an be used in clusterolebinding
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 15, 2025
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
@chmouel
Copy link
Member

chmouel commented Jan 15, 2025

thanks 🙏🏻

i think we can force approve to unlock ci

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@piyush-garg piyush-garg force-pushed the fix_e2e branch 17 times, most recently from 773146f to 4c1e9b2 Compare January 16, 2025 09:31
@piyush-garg piyush-garg force-pushed the fix_e2e branch 7 times, most recently from 149f7c3 to 91268d3 Compare January 16, 2025 18:59
@vdemeester
Copy link
Member

vdemeester commented Jan 20, 2025

The CI should be green though 🤔

@vdemeester
Copy link
Member

vdemeester commented Jan 20, 2025 

     eventListener_test.go:93: assertion failed: 
        Actual output: 
        
        Missing strings: github-listener-interceptor-el-github-listener-interceptor-, el-github-listener-interceptor-7f578745b4-pcnx4

The issue is different but still legit I think.

@divyansh42 divyansh42 mentioned this pull request Jan 24, 2025
Closed
4 tasks
@piyush-garg piyush-garg force-pushed the fix_e2e branch 4 times, most recently from ad5c381 to 0a8c384 Compare January 25, 2025 02:37
@piyush-garg
Fix eventlistener permissions and tests
624bfb7 
This will fix eventlistener permissions and will send
a dummy event to trigger logs
@piyush-garg
Copy link
Contributor Author

piyush-garg commented Jan 25, 2025

/retest

@piyush-garg
Copy link
Contributor Author

piyush-garg commented Jan 25, 2025

@vdemeester @chmouel @divyansh42 @pratap0007 Fixed the tests

@divyansh42
Copy link
Member

divyansh42 commented Jan 25, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2025
@vdemeester
Copy link
Member

vdemeester commented Jan 25, 2025

/approve

@tekton-robot
Copy link
Contributor

tekton-robot commented Jan 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2025
@tekton-robot tekton-robot merged commit 7738862 into tektoncd:main Jan 25, 2025
2 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chmouel chmouel Awaiting requested review from chmouel

@divyansh42 divyansh42 Awaiting requested review from divyansh42

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@chmouel chmouel

@divyansh42 divyansh42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@piyush-garg @chmouel @vdemeester @divyansh42 @tekton-robot