Fix deadlock issue when following logs#2556
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Jun 23, 2025
Merged
Conversation
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
the
size/M
divyansh42
force-pushed
the
fix-logs-deadlock
branch
from
6c8d5f9 to
b1434b9
Compare
Member
Author
|
/retest |
divyansh42
force-pushed
the
fix-logs-deadlock
branch
from
b1434b9 to
a30283f
Compare
tekton-robot
added
size/L
divyansh42
force-pushed
the
fix-logs-deadlock
branch
from
3622130 to
6d3db03
Compare
Signed-off-by: divyansh42 <[email protected]>
divyansh42
force-pushed
the
fix-logs-deadlock
branch
from
6d3db03 to
412af88
Compare
tekton-robot
added
size/M
divyansh42
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
We've been hitting the original problem in our team on almost every 3rd run. I've tested @divyansh42 's fixes extensively over the past couple of days, and can confirm I have not hit the problem with them and the runs look correct. |
Contributor
|
/lgtm |
Contributor
vdemeester
approved these changes
Jun 23, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vinamra28
added a commit
that referenced
this pull request
Jul 14, 2025
#2548 | [dependabot[bot]] Bump the go-docker-dependencies group with 2 updates | 2025/05/30-06:18 #2544 | [vinamra28] Update CLI docs for tkn v0.41.0 | 2025/05/30-07:58 #2525 | [Abhishek Ghosh] Add flag to prefix log lines with log source (task and step name) by default | 2025/06/05-16:57 #2525 | [Abhishek Ghosh] updated the docs | 2025/06/05-16:57 #2525 | [Abhishek Ghosh] Add unit test scripts | 2025/06/05-16:57 #2525 | [Abhishek Ghosh] Adjust pipeline logs test to align with updated output format | 2025/06/05-16:57 #2549 | [dependabot[bot]] Bump the go-docker-dependencies group with 2 updates | 2025/06/10-10:07 #2553 | [Chmouel Boudjnah] fix: update Pending color of PipelineRunPending | 2025/06/11-14:51 #2552 | [dependabot[bot]] Bump github.com/cloudflare/circl from 1.3.7 to 1.6.1 | 2025/06/13-06:33 #2556 | [divyansh42] Fix deadlock issue when following logs | 2025/06/23-17:15 null | [dependabot[bot]] Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 in /tools | 2025/06/30-07:27 Signed-off-by: vinamra28 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes: #2484
Removed eventC channel and used variables with some logic changes to avoid the deadlock condition
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes