Conversation
bsideup
added
type/breaking-api-change
This was referenced Jun 16, 2020
rnorth
reviewed
Jun 30, 2020
core/src/main/java/org/testcontainers/images/TimeLimitedLoggedPullImageResultCallback.java
Outdated
Show resolved
Hide resolved
rnorth
requested changes
Jul 5, 2020
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
I only had one comment, on a Javadoc change of all things 😂
…esultCallback`'s javadoc
rnorth
approved these changes
Jul 9, 2020
rnorth
added a commit
to usmanovbf/testcontainers-java
that referenced
this pull request
Jul 9, 2020
Any plans to unshade it all? I'm still getting nasty classpath clashes: I need to be able to use the real |
dagguh
added a commit
to atlassian/virtual-users
that referenced
this pull request
Sep 8, 2020
Unblock the main API integration test. Here's the [original rationale] for ignoring it. In the meantime there was some progress from `testcontainers` to [reduce the class copy-paste]. This allows us to work with `docker-java-api`, which no longer clashes. However, they're still shading `docker-java-core`, so we gotta depend on their copy for now. Currently their copy is compatible with the rest of our code. It's still messy, but we can stop depending on them later. [original rationale]: 29c29fc [reduce the class copy-paste] : testcontainers/testcontainers-java#2882
dagguh
added a commit
to atlassian/virtual-users
that referenced
this pull request
Sep 9, 2020
Unblock the main API integration test. Here's the [original rationale] for ignoring it. In the meantime there was some progress from `testcontainers` to [reduce the class copy-paste]. This allows us to work with `docker-java-api`, which no longer clashes. However, they're still shading `docker-java-core`, so we gotta depend on their copy for now. Currently their copy is compatible with the rest of our code. It's still messy, but we can stop depending on them later. [original rationale]: 29c29fc [reduce the class copy-paste] : testcontainers/testcontainers-java#2882
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Testcontainers depend on
docker-java-apiinstead of including it into our JAR unshaded. Note thatdocker-java-coreanddocker-java-transport-okhttpremain shaded due to their transitive dependencies like Guava or now-in-Kotlin OkHttp.The transition requires a breaking change in the
DockerClientProviderStrategyAPI and includes a rework.The rework also includes an improvement that removes one Docker API call (
/_ping) and instead reuses the/_infoone (reduces the startup by ~200ms).The dependency graph now looks like this:
While previously it was:
Fixes #1113