This repository was archived by the owner on Jan 28, 2026. It is now read-only.
fix: Error decoding command output on Windows#11
Merged
timerring merged 1 commit intotimerring:mainfrom Jan 12, 2025
Merged
Conversation
timerring
reviewed
Jan 12, 2025
Owner
timerring
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the correction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a
UnicodeDecodeErrorthat occurs on Windows systems when decoding command output. The issue arises due to the default encoding (gbk) being unable to handle certain byte sequences, as shown in the error traceback:Additionally, the error propagates to cause a
TypeErrorwhen attempting to parseNoneas JSON:This fix ensures proper handling of command output encoding to prevent such errors.