Use iconv.decodeStream instead of iconv.decode; Fixes #374#375
Use iconv.decodeStream instead of iconv.decode; Fixes #374#375tomas merged 6 commits intotomas:masterfrom yetzt:patch-1
iconv.decodeStream instead of iconv.decode; Fixes #374#375Conversation
|
Thanks for the PR! IIRC a long time ago I tried using iconv's stream interface but wasn't able to for some reason. Are you sure this won't break anything? |
|
Also, does the test suite pass 100% on your end? |
|
i'd like to refactor i haven't run tests yet. |
|
the tests from |
|
i extended the tests to include euc-jp and gb18030, omitted decoding if the charset is already utf-8 and ensured the charset found in the magic charset detection is one iconv can actually handle. (more elegant code would be possible without the magic inline charset detection though) |
|
Beautiful. Will take a look when I have a minute. |
Use iconv.decodeStream instead of iconv.decode; Fixes #374