Show the names of tests that fail sandbox violation#5585
Show the names of tests that fail sandbox violation#5585ceedubs merged 1 commit intounisonweb:trunkfrom
Conversation
Previously if a test violated the sandbox such as with `Debug.trace`, the output just said `pure code can't perform I/O` but didn't actually report any failing tests or even name the test that violated the sandbox. With this change it will at least add a line like: ``` Error while evaluating test `bar.test` ``` This should help a lot in tracking down the sandbox violation. This resolves the worst of [unisonweb#4685](unisonweb#4685), but it doesn't do anything to address the confusing behavior of test watches being exempt from the sandbox and caching tests that would fail when running `test` on an empty cache.
ceedubs
force-pushed
the
name-test-sandbox-violators
branch
from
ed2e63a to
d9b9384
Compare
|
I'm not sure what to do about the latter problem. I think the idea is that when you're adding tests with watch expressions, you're writing code running on your own machine, so there's more trust. But I don't know that we want to remove the latter, but I guess we could try to add the same restrictions to the former for things that are getting added as tests. |
|
@dolio the answer might be to just allow There is some potentially surprising behavior with the traces not showing up once results are cached. But that probably isn't such a big deal. |
3 participants
Previously if a test violated the sandbox such as with
Debug.trace, the outputjust said
pure code can't perform I/Obut didn't actually report any failingtests or even name the test that violated the sandbox.
With this change it will at least add a line like:
This should help a lot in tracking down the sandbox violation.
This resolves the worst of #4685, but it doesn't do anything to address the confusing behavior of test watches being exempt from the sandbox and caching tests that would fail when running
teston an empty cache.