Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR deletes the mostly-obsolete
namespace.dependenciescommand, and recommends runningtodointead.There's one minor snag, which is that
namespace.dependenciesaccepted an optional path, whereastododoes not, and only reports nameless dependencies in the context of a project. However, I think that's find & good – it's not really expected that a sub-namespace of a project is self-contained, since only the top-level has library dependencies in scope, and we've long since moved away fromcd-style development. So, all together, I think it's better to just delete the oldnamespace.dependenciescommand entirely, and if we ever recover some sensible sub-project concept we can iterate from there.