fix full type definition not being shown for new type defs in diff.update#6101
Merged
aryairani merged 3 commits intounisonweb:trunkfrom Jan 29, 2026
Merged
fix full type definition not being shown for new type defs in diff.update#6101aryairani merged 3 commits intounisonweb:trunkfrom
aryairani merged 3 commits intounisonweb:trunkfrom
Conversation
aryairani
reviewed
Jan 14, 2026
| @@ -2654,21 +2654,24 @@ notifyUser dir issueFn = \case | |||
| let ppe = PPED.suffixifiedPPE ppedNew | |||
| let colorAdd = P.green . ("+ " <>) | |||
Contributor
There was a problem hiding this comment.
Looks like this definition is no longer used, was that intentional? Or maybe it got copied somewhere else?
It's hitting "warnings as errors" in CI.
ca7ab6a to
6833be0
Compare
Contributor
|
@bbarker I've been trying to coax this PR through too, but got interrupted. I think I can get it though, so don't worry. For future PRs though, the gold standard is to run Feel free to ping me on Discord if you wanna troubleshoot together in the future though. |
aryairani
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
diff.updatecommand now shows the full structure of new types and abilities, not just their names.Before:
After:
This matches the behavior for updated types, which already showed their full structure with inline diffs.
Implementation approach and notes
Changed
renderNewTypesinOutputMessages.hsto useDeclPrinter.prettyDecl(full declaration rendering) instead ofDeclPrinter.prettyDeclOrBuiltinHeader(header only). This required threadingTypeReferenceIdthrough fromDiffUpdate.hsand updating theShowUpdateDifftype inOutput.hs.Test coverage
unison-src/transcripts/idempotent/diff-update.mdthat covers new structural types and abilitiesLoose ends
None.
Final checklist