fix accidental swap of local<->remote in difftool invocation#6158
Merged
fix accidental swap of local<->remote in difftool invocation#6158
Conversation
Contributor
|
Awesome, thanks |
aryairani
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #6157
This PR fixes the accidental swapping of "local" & "remote" in the difftool invocation. It's a little hard to capture in a test since the fix doesn't affect the ucm-rendered difference between the branches, but here is a screenshot of it working:
This is just showing a run with
UCM_DIFFTOOL='echo $LOCAL $REMOTE'. On trunk, we'd echono matter the argument order. On this branch, the argument order is reflected in the arguments passed to the difftool.