Conversation
Contributor
|
Nice! |
aryairani
approved these changes
Feb 12, 2026
aryairani
removed this pull request from the merge queue due to the queue being cleared
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Member
|
Oh this is great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3707
Overview
This PR changes the behavior of
viewandeditto include docs automatically.I initially endeavored to just change the behavior of
editas the ticket originally requests, but sinceviewandeditshare so much code, it was simpler to affect both. It's also useful to see docs of something that you justview, though I think an improvement might be to properlydisplaythe doc rather than just show the semi-pretty-printed version you currently get.Test coverage
No new tests, but existing transcripts cover the change.
Loose ends
I realized rather late in development that the internal mechanism has an annoying corner case. The feature is currently implemented in two stages:
edit x y ztoedit x y z x.doc y.doc z.docHowever, I forgot about suffixification. There is some code related to essentially not displaying "stuff that the user didn't ask for" that I don't think would be necessary with the simpler idea of:
I didn't think it was really worth eagerly reworking all of the internals, since this way works, it's just arguably not the best design.