consolidate checks to a single result, in the absence of mergify#6171
Merged
consolidate checks to a single result, in the absence of mergify#6171
Conversation
How is this different from just requiring merge queue tests to pass? `merge-queue-tests` isn't reported as a single status check by GitHub. Since it calls a reusable workflow (uses: ./.github/workflows/test.yaml), GitHub reports the individual jobs from test.yaml as separate checks, e.g.: merge queue tests / build ucm (ubuntu-24.04) merge queue tests / build ucm (macos-latest) merge queue tests / transcripts (ubuntu-24.04) merge queue tests / dll-ffi (ubuntu-24.04) ...etc There's no single "merge queue tests" check to require. You'd have to enumerate all of those individually, and update the list whenever you add/remove an OS or job. The gate job creates one concrete check (merge queue gate) that you can require, and it transitively covers everything via needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to the merge-queue setup from #6150