Skip to content

fix(dashboard): reset name input field after creating root key#1703

Merged
chronark merged 2 commits intounkeyed:mainfrom
DeepaPrasanna:fix/clear-name-input-after-creating-root-key
May 31, 2024
Merged

fix(dashboard): reset name input field after creating root key#1703
chronark merged 2 commits intounkeyed:mainfrom
DeepaPrasanna:fix/clear-name-input-after-creating-root-key

Conversation

@DeepaPrasanna
Copy link
Contributor

@DeepaPrasanna DeepaPrasanna commented May 31, 2024

What does this PR do?

Fixes #1702

Resets the name input field after creating the root key.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Mention the name and permissions while creating the root key. After closing the pop up dialog, the name should also be cleared along with permissions.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6ff0d54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 31, 2024

@DeepaPrasanna is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented May 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@chronark chronark enabled auto-merge May 31, 2024 08:24
@vercel
Copy link

vercel bot commented May 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 8:33am
planetfall ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 8:33am
workflows ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 8:33am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 8:33am

@vercel vercel bot temporarily deployed to Preview – www May 31, 2024 08:29 Inactive
@vercel vercel bot temporarily deployed to Preview – planetfall May 31, 2024 08:30 Inactive
@vercel vercel bot temporarily deployed to Preview – workflows May 31, 2024 08:32 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard May 31, 2024 08:33 Inactive
@chronark chronark added this pull request to the merge queue May 31, 2024
Merged via the queue into unkeyed:main with commit 2dd9c7d May 31, 2024
@DeepaPrasanna DeepaPrasanna deleted the fix/clear-name-input-after-creating-root-key branch May 31, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chronark chronark chronark approved these changes

@perkinsjr perkinsjr Awaiting requested review from perkinsjr perkinsjr is a code owner

@guilhermerodz guilhermerodz Awaiting requested review from guilhermerodz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

name input field does not clears after creating root key

3 participants

@DeepaPrasanna @CLAassistant @chronark