Skip to content

fix: correct gitHub clone URL to use HTTPS#1740

Merged
perkinsjr merged 2 commits intounkeyed:mainfrom
DeepaPrasanna:patch-1
Jun 11, 2024
Merged

fix: correct gitHub clone URL to use HTTPS#1740
perkinsjr merged 2 commits intounkeyed:mainfrom
DeepaPrasanna:patch-1

Conversation

@DeepaPrasanna
Copy link
Contributor

@DeepaPrasanna DeepaPrasanna commented Jun 11, 2024

What does this PR do?

Fixes #1739

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Copy & run the github clone url

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c6694c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 11, 2024

@DeepaPrasanna is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@perkinsjr perkinsjr changed the title correct gitHub clone URL to use HTTPS fix: correct gitHub clone URL to use HTTPS Jun 11, 2024
@perkinsjr perkinsjr merged commit f9465fc into unkeyed:main Jun 11, 2024
@DeepaPrasanna DeepaPrasanna deleted the patch-1 branch June 11, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perkinsjr perkinsjr perkinsjr approved these changes

@chronark chronark Awaiting requested review from chronark chronark is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[docs] correct github clone URL

2 participants

@DeepaPrasanna @perkinsjr