Skip to content

fix: add flags to pnpm local#1943

Merged
chronark merged 6 commits intounkeyed:mainfrom
DeepaPrasanna:fix/add-flags-in-pnpm-local
Jul 23, 2024
Merged

fix: add flags to pnpm local#1943
chronark merged 6 commits intounkeyed:mainfrom
DeepaPrasanna:fix/add-flags-in-pnpm-local

Conversation

@DeepaPrasanna
Copy link
Contributor

@DeepaPrasanna DeepaPrasanna commented Jul 19, 2024 •
edited
Loading

What does this PR do?

add --service and --skip-env flags to pnpm local command

Fixes #1878

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Run the command pnpm local --service=dashboard --skip-env

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Note: I believe docs should be updated too regarding the flags

@DeepaPrasanna
fix: add flags to pnpm local
193b1ac 
add --service and --skip-env flags
@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c075295

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 19, 2024

@DeepaPrasanna is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@harshsbhat
Copy link
Contributor

harshsbhat commented Jul 20, 2024

Good one!

chronark
chronark reviewed Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@chronark chronark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can you add a README to the package and document the flags?

@vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 9:09am
planetfall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 9:09am
workflows ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 9:09am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 9:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
play ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 9:09am

@chronark chronark enabled auto-merge July 23, 2024 08:58
@vercel vercel bot temporarily deployed to Preview – planetfall July 23, 2024 09:07 Inactive
@vercel vercel bot temporarily deployed to Preview – dashboard July 23, 2024 09:08 Inactive
@vercel vercel bot temporarily deployed to Preview – workflows July 23, 2024 09:09 Inactive
@vercel vercel bot temporarily deployed to Preview – www July 23, 2024 09:09 Inactive
@chronark chronark added this pull request to the merge queue Jul 23, 2024
Merged via the queue into unkeyed:main with commit 0148361 Jul 23, 2024
@DeepaPrasanna DeepaPrasanna deleted the fix/add-flags-in-pnpm-local branch July 23, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chronark chronark chronark approved these changes

@perkinsjr perkinsjr Awaiting requested review from perkinsjr perkinsjr is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pnpm local should accept flags to bypass manual input questions

3 participants

@DeepaPrasanna @harshsbhat @chronark