Conversation
harshsbhat
requested review from
MichaelUnkey,
chronark,
mcstepp and
perkinsjr
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@harshsbhat is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
📝 WalkthroughWalkthroughThis pull request includes updates to various components and documentation within the codebase, specifically changing URLs that link to a booking page. The modifications affect the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/dashboard/app/(app)/settings/billing/plans/page.tsx (1)
48-48: LGTM! Consider adding a comment for clarity.The updated URL correctly addresses the broken link issue mentioned in #2172. The addition of UTM parameters is a good practice for tracking the effectiveness of this call-to-action.
Consider adding a brief comment explaining the purpose of the UTM parameters for future maintainability:
custom: { name: "Custom", + // URL for scheduling custom pricing calls with UTM parameters for tracking href: "https://cal.com/team/unkey/user-interview?utm_source=banner&utm_campaign=oss", price: "Let's talk", description: "We offer custom pricing for those with volume needs",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
- README.md (1 hunks)
- apps/dashboard/app/(app)/settings/billing/plans/page.tsx (1 hunks)
- apps/www/components/cta.tsx (1 hunks)
- apps/www/components/footer/footer.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- README.md
🔇 Additional comments (3)
apps/www/components/footer/footer.tsx (2)
Line range hint
1-114: Summary: Cal.com booking link successfully updatedThe changes in this file are minimal and focused, addressing the broken Cal.com booking page link as described in the PR objectives. The update fixes the issue #2172 where the booking page was returning a 404 error. No other modifications were made to the file, maintaining the existing structure and functionality of the footer component.
46-46: LGTM! URL updated correctly.The change addresses the broken Cal.com booking page link as mentioned in the PR objectives. The new URL structure looks correct and maintains the necessary parameters.
To ensure the new link works as expected, please run the following verification:
✅ Verification successful
URL update verified successfully.
The updated Cal.com booking link (
https://cal.com/team/unkey/user-interview?utm_source=banner&utm_campaign=oss) is functioning correctly and returns an HTTP 200 status code.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated Cal.com booking link # Test: Check if the new URL returns a valid response curl -I https://cal.com/team/unkey/user-interview?utm_source=banner&utm_campaign=oss # Expected result: HTTP status code 200 OK # If the result is different, please review the URL againLength of output: 1040
Script:
#!/bin/bash # Description: Verify the updated Cal.com booking link with all UTM parameters # Test: Check if the new URL with utm_source and utm_campaign returns a valid response curl -I 'https://cal.com/team/unkey/user-interview?utm_source=banner&utm_campaign=oss' # Expected result: HTTP status code 200 OK # If the result is different, please review the URL againLength of output: 959
apps/www/components/cta.tsx (1)
22-25: LGTM! The Cal.com link has been updated correctly.The change from "unkey-chat" to "user-interview" in the Cal.com link addresses the issue #2172 where the booking page was returning a 404 error. The addition of the
utm_source=bannerparameter will also help with tracking the source of these bookings.To ensure this change resolves the issue across the entire codebase, please run the following script:
This script will help ensure that all instances of the old link have been updated throughout the codebase.
✅ Verification successful
Verification Successful: All Cal.com links updated correctly.
All instances of the old Cal.com link have been updated to "https://cal.com/team/unkey/user-interview?utm_source=banner&utm_campaign=oss" in the following files:
apps/www/components/cta.tsxapps/www/components/footer/footer.tsxapps/dashboard/app/(app)/settings/billing/plans/page.tsx🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all occurrences of the Cal.com link have been updated # Test: Search for any remaining instances of the old link rg --type-add 'web:*.{ts,tsx,js,jsx}' --type web 'https://cal.com/team/unkey/unkey-chat' # Test: Confirm the new link is present rg --type-add 'web:*.{ts,tsx,js,jsx}' --type web 'https://cal.com/team/unkey/user-interview'Length of output: 586
|
Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat |
|
/assign |
|
You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more. |
3 participants
What does this PR do?
FIxed the cal.com link in 4+ instances
Fixes #2172
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
How should this be tested?
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit
New Features
Documentation