Skip to content

docs: document pnpm flags in getting started page#2229

Merged
chronark merged 1 commit intounkeyed:mainfrom
DeepaPrasanna:docs/show-pnpm-flags
Oct 7, 2024
Merged

docs: document pnpm flags in getting started page#2229
chronark merged 1 commit intounkeyed:mainfrom
DeepaPrasanna:docs/show-pnpm-flags

Conversation

@DeepaPrasanna
Copy link
Contributor

@DeepaPrasanna DeepaPrasanna commented Oct 6, 2024

What does this PR do?

Fixes #2227

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • The getting started page should include the information about the flags now.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features

    • Added a new subsection in the documentation about the pnpm local command, allowing users to bypass manual input during setup.
    • Included detailed explanations and examples for using the --service and --skip-env flags.
  • Documentation

    • Enhanced the "Web Application / Marketing Site" section with additional guidance for users.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2024

⚠️ No Changeset found

Latest commit: 31d4358

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 10:08am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 6, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request enhance the documentation for the pnpm local command within the "Web Application / Marketing Site" section. A new subsection titled "About pnpm local command" has been added, explaining how users can bypass manual input questions during setup if they have previously configured Unkey. It details the command's usage, including options such as --service and --skip-env, along with examples for better clarity.

Changes

File Path Change Summary
apps/docs/contributing/getting-started.mdx Added a new subsection on the pnpm local command, explaining usage and options with examples.

Assessment against linked issues

Objective Addressed Explanation
Show the flags added to the pnpm local (#2227)

Suggested labels

Documentation, 🕹️ oss.gg, :joystick: 150 points, hacktoberfest

Suggested reviewers

  • perkinsjr
  • chronark

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Oct 6, 2024

@DeepaPrasanna is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added 🕹️ 150 points Documentation Improvements or additions to documentation Good first issue Good for newcomers labels Oct 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@vercel vercel bot temporarily deployed to Preview – engineering October 6, 2024 10:08 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
apps/docs/contributing/getting-started.mdx (1)

72-90: Great addition of pnpm local command documentation!

The new section effectively addresses the PR objectives by documenting the flags for the pnpm local command. This information will be valuable for new developers. Here are a few suggestions to further improve the content:

  1. Remove the space before the colon in the following lines:

    - - `--service=<service>` : Specifies which part of the application to develop.
    + - `--service=<service>`: Specifies which part of the application to develop.
  2. Consider adjusting the indentation of the code blocks for consistency with the rest of the document. For example:

    -    ```bash
    -    pnpm local [options]
    -    ```
    +```bash
    +pnpm local [options]
    +```
  3. Enhance the explanation of the --service flag to clarify its purpose:

    - - `--service=<service>`: Specifies which part of the application to develop. The values are `dashboard`, `api`, or `www`
    + - `--service=<service>`: Specifies which part of the application to develop. This determines which environment files will be set up. The values are `dashboard`, `api`, or `www`
🧰 Tools
🪛 LanguageTool

[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...lable options: - --service=<service> : Specifies which part of the application...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~84-~84: Loose punctuation mark.
Context: ...hboard, api, or www ---skip-env`: Skips the environment setup prompt if s...

(UNLIKELY_OPENING_PUNCTUATION)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 07d5b86 and 31d4358.

📒 Files selected for processing (1)
  • apps/docs/contributing/getting-started.mdx (1 hunks)
🧰 Additional context used
🪛 LanguageTool
apps/docs/contributing/getting-started.mdx

[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...lable options: - --service=<service> : Specifies which part of the application...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~84-~84: Loose punctuation mark.
Context: ...hboard, api, or www ---skip-env`: Skips the environment setup prompt if s...

(UNLIKELY_OPENING_PUNCTUATION)

@harshsbhat
Copy link
Contributor

Hey @DeepaPrasanna, If @chronark approves can you also add the

pnpm test:integration [filepath]

in the test documentation? It is also one of the shortcuts to run tests for a single API route.

@chronark chronark merged commit df9349f into unkeyed:main Oct 7, 2024
@oss-gg
Copy link

oss-gg bot commented Oct 7, 2024

Awarding DeepaPrasanna: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/DeepaPrasanna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Show the flags added to the pnpm local

3 participants