Skip to content

feat(gittag): add the parameter tag for gittag#7486

Merged
olblak merged 7 commits intoupdatecli:mainfrom
josill:feat/gittag-tag-parameter
Jan 14, 2026
Merged

feat(gittag): add the parameter tag for gittag#7486
olblak merged 7 commits intoupdatecli:mainfrom
josill:feat/gittag-tag-parameter

Conversation

@josill
Copy link
Contributor

@josill josill commented Jan 11, 2026

Fix #1394

Adds missing tag parameter to gittag plugin's Spec struct, making it consistent with gitea/tag, gitlab/tag, and stash/tag plugins.

When disablesourceinput: true is set, the condition can now check for an exact tag match using spec.tag instead of requiring versionfilter.pattern.

Changes

  • Added Tag field to gittag.Spec struct
  • Updated Condition function to support exact tag matching when spec.Tag is provided
  • Priority: spec.Tag > source > versionFilter.Pattern
  • Added unit tests for tag-based condition checking
  • Added e2e test cases using the new tag parameter

Test

go test ./pkg/plugins/resources/gittag/... -v## Additional Information

Checklist

  • Code follows project conventions
  • Unit tests added
  • E2e tests added
  • Backward compatible with existing versionFilter usage

@josill josill marked this pull request as ready for review January 11, 2026 20:25
olblak
olblak requested changes Jan 12, 2026
View reviewed changes
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.
Could I ask you to fix the linter issue ?
Also I think I spotted a duplicated line that could be removed

@josill
Copy link
Contributor Author

josill commented Jan 12, 2026

Thanks for the pull request. Could I ask you to fix the linter issue ? Also I think I spotted a duplicated line that could be removed

Fixed the duplicate line and the linter issue. Should be good now. Ill take more time to review my code next time. Thanks!

@josill josill requested a review from olblak January 12, 2026 19:40
@olblak olblak enabled auto-merge (squash) January 13, 2026 19:05
@olblak olblak added enhancement New feature or request resource-gittag Resource of kind Git Tag gitea-tag labels Jan 13, 2026
@olblak olblak merged commit bd9edca into updatecli:main Jan 14, 2026
5 of 6 checks passed
@olblak olblak changed the title feat: add the parameter tag for gittag feat(gittag): add the parameter tag for gittag Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olblak olblak olblak approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request gitea-tag resource-gittag Resource of kind Git Tag

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: gittag plugin is missing the parameter tag

2 participants

@josill @olblak