fix(file): file target bug with searchpattern and matchpattern#7629
Merged
olblak merged 3 commits intoupdatecli:mainfrom Jan 29, 2026
Merged
fix(file): file target bug with searchpattern and matchpattern#7629olblak merged 3 commits intoupdatecli:mainfrom
olblak merged 3 commits intoupdatecli:mainfrom
Conversation
josill
force-pushed
the
fix/file-target-bug-2
branch
from
70e2f4d to
24bee26
Compare
josill
changed the title
Contributor
Author
|
Sorry for the confusion I closed my previous PR and opened a new one because of the unrelated changes that I needed to revert. Tried to revert them with AI but that was a bad idea and screwed up the branch history. Did this manually now and fixed the comments from the CR: #7614 |
Member
Member
|
You can easily do it using the |
josill
force-pushed
the
fix/file-target-bug-2
branch
from
24bee26 to
f8d19c4
Compare
josill
force-pushed
the
fix/file-target-bug-2
branch
from
f8d19c4 to
2a42d26
Compare
Contributor
Author
|
All fixed and thanks for the patience. Turns out my fork had commits in main that this repo didn't - my bad! Should be all good now! Again, Ill turn more attention to the CR-s in the future. |
Signed-off-by: Olblak <[email protected]>
olblak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1860
Fix inconsistent behavior when using
searchpattern: truewithmatchpatternwhere no files match the content pattern.Changes
searchpattern: trueis used withmatchpatternand all files are filtered out (no matches), the target now returns an error instead of silently skippingsearchpattern: falseandsearchpattern: truenow fail consistently when no files match the patternTest
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
The change modifies behavior for users who relied on the previous silent skip when no files matched with
searchpattern: true. However, this was inconsistent with the behavior whensearchpattern: false, and the issue maintainer confirmed this was a bug that should be fixed.Potential improvement
A future enhancement could add a
matchatleastparameter to allow specifying a minimum number of files that must match before the operation succeeds, providing more flexibility for users who need partial matching scenarios.