Add more tests to improve code coverage#2237
Merged
dearchap merged 1 commit intourfave:mainfrom Nov 30, 2025
Merged
Conversation
Juneezee
approved these changes
Nov 30, 2025
mustafabayar
reviewed
Feb 3, 2026
| } | ||
|
|
||
| if exitErr, ok := err.(ExitCoder); ok { | ||
| if err.Error() != "" { |
There was a problem hiding this comment.
@dearchap was this code change intentional? Calling Exit with an empty message now adds an unnecessary empty line to stderr:
cli.Exit("", exitError.ExitCode())
3 tasks
radermacher-iits
pushed a commit
to kubara-io/kubara
that referenced
this pull request
Feb 19, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/urfave/cli/v3](https://github.com/urfave/cli) | require | patch | `v3.6.1` → `v3.6.2` | --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v3)</summary> ### [`v3.6.2`](https://github.com/urfave/cli/releases/tag/v3.6.2) [Compare Source](urfave/cli@v3.6.1...v3.6.2) #### What's Changed - chore(deps): bump actions/checkout from 5 to 6 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2230](urfave/cli#2230) - chore(deps): bump mkdocs-material from 9.6.23 to 9.7.0 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2231](urfave/cli#2231) - Improve test coverage by [@​dearchap](https://github.com/dearchap) in [#​2236](urfave/cli#2236) - Add more tests to improve code coverage by [@​dearchap](https://github.com/dearchap) in [#​2237](urfave/cli#2237) - Fix:(issue\_2238) Dont process flags for completion command by [@​dearchap](https://github.com/dearchap) in [#​2239](urfave/cli#2239) - Fix:(issue\_2228) Fix for default command by [@​dearchap](https://github.com/dearchap) in [#​2232](urfave/cli#2232) - chore(deps): bump mkdocs-material from 9.7.0 to 9.7.1 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2242](urfave/cli#2242) - Docs: correct typo in migration guide by [@​kzygmans](https://github.com/kzygmans) in [#​2243](urfave/cli#2243) - Fix:(issue\_2244) Dont check req flags for help and completion commands by [@​dearchap](https://github.com/dearchap) in [#​2245](urfave/cli#2245) - Only show separator if command has usage text by [@​mikecluck](https://github.com/mikecluck) in [#​2247](urfave/cli#2247) #### New Contributors - [@​kzygmans](https://github.com/kzygmans) made their first contribution in [#​2243](urfave/cli#2243) - [@​mikecluck](https://github.com/mikecluck) made their first contribution in [#​2247](urfave/cli#2247) **Full Changelog**: <urfave/cli@v3.6.1...v3.6.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44NC4yIiwidXBkYXRlZEluVmVyIjoiNDIuODQuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119--> Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Improve test coverage to beyond 99%
Which issue(s) this PR fixes:
(REQUIRED)
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
make test
Release Notes
(REQUIRED)