date, comm, tty: Fixing handling output to dev/null#10888
Merged
sylvestre merged 3 commits intouutils:mainfrom Feb 12, 2026
Merged
date, comm, tty: Fixing handling output to dev/null#10888sylvestre merged 3 commits intouutils:mainfrom
sylvestre merged 3 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were part of the new test cases added to the io-error gnu test where we have a mix of different causes that make us provide the wrong exit code and error message. In date, there was no flush before the WriteBuf was dropped so there was no error handling. In tty, we ignored the pipeline signal before the clap handling and in GNU the expectation is that this is done after the argument handling and in comm we flushed the buffer but we ignored the error message.
This should make the io-error gnu test pass now.