Skip to content

expr: Handle more special cases for regex pattern#7974

Merged
cakebaker merged 5 commits intouutils:mainfrom
frendsick:fix/expr-regex-special-cases
May 25, 2025
Merged

expr: Handle more special cases for regex pattern#7974
cakebaker merged 5 commits intouutils:mainfrom
frendsick:fix/expr-regex-special-cases

Conversation

@frendsick
Copy link
Contributor

@frendsick frendsick commented May 23, 2025

Handle the following special cases for regex patterns for expr and add tests for them:

  • Trailing backslashes
  • $ at the beginning of the regex pattern

@frendsick frendsick force-pushed the fix/expr-regex-special-cases branch from fcb506f to b0390fe Compare May 23, 2025 22:48
@frendsick
Copy link
Contributor Author

frendsick commented May 23, 2025

What should I do with the test_regex function that is failing the clippy::too_many_lines lint from clippy::pedantic? Should it be allowed to have more lines, as the nature of the current function is that it contains many regex tests, or should it be refactored to smaller test functions for each tested use case? Of course, one use case can have multiple new_ucmd tests, like testing special cases with parsing the $ character.

@github-actions
Copy link

github-actions bot commented May 23, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented May 24, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed May 24, 2025
View reviewed changes
cakebaker
cakebaker reviewed May 24, 2025
View reviewed changes
@frendsick
Copy link
Contributor Author

frendsick commented May 24, 2025

Thank you for the review. I will check these when I have the time, possibly tomorrow.

@frendsick frendsick requested a review from cakebaker May 24, 2025 18:20
@github-actions
Copy link

github-actions bot commented May 24, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 3f9514d into uutils:main May 25, 2025
73 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented May 25, 2025

Thanks!

@frendsick frendsick deleted the fix/expr-regex-special-cases branch May 25, 2025 11:42
@BrewTestBot BrewTestBot mentioned this pull request Sep 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frendsick @cakebaker