Skip to content

Commit 753c582

Browse files
jakobkummerowV8 LUCI CQ
jakobkummerow
authored and
V8 LUCI CQ
committed
[test][wasm] Migrate to new "addArray(type, {options})" syntax
This replaces callers of the old API: addArray(type, mutability, supertype, final, shared) with the newer options bag alternative: addArray(type, {mutable: ..., supertype: ..., final: ..., shared: ...}) and also drops parameters that match the implicit default. No change in behavior or test coverage is intended. Change-Id: Id7eb4a0417634b322cb204fcbe3677aacfb3136a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7670839 Reviewed-by: Matthias Liedtke <[email protected]> Commit-Queue: Matthias Liedtke <[email protected]> Auto-Submit: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/main@{#105843}
1 parent b05e320 commit 753c582

File tree

125 files changed

+355
-333
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

125 files changed

+355
-333
lines changed

‎test/filecheck/js-wasm-wrapper-inlining-lazy-deopt.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ let arrayIndex = 0;
1414
function createWasmModuleForLazyDeopt(returnType, createValue, callback) {
1515
let builder = new WasmModuleBuilder();
1616
builder.addMemory(1, 1);
17-
let index = builder.addArray(kWasmI32, true);
17+
let index = builder.addArray(kWasmI32);
1818
assertEquals(arrayIndex, index);
1919
let callbackIndex = builder.addImport('env', 'callback', kSig_v_i);
2020

‎test/filecheck/wasm-in-js-inlining-turboshaft.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ d8.file.execute("test/mjsunit/wasm/wasm-module-builder.js");
1515
d8.file.execute("test/mjsunit/mjsunit.js");
1616

1717
const builder = new WasmModuleBuilder();
18-
const array = builder.addArray(kWasmI32, true);
18+
const array = builder.addArray(kWasmI32);
1919
const globalI32 = builder.addGlobal(kWasmI32, true, false);
2020
const globalEqRef = builder.addGlobal(kWasmEqRef, true, false);
2121

‎test/inspector/debugger/wasm-gc-anyref.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ async function instantiateWasm() {
6767
var builder = new WasmModuleBuilder();
6868
builder.startRecGroup();
6969
let struct_type = builder.addStruct([makeField(kWasmI32, false)]);
70-
let array_type = builder.addArray(kWasmI32);
70+
let array_type = builder.addArray(kWasmI32, {mutable: false});
7171
let imported_ref_table =
7272
builder.addImportedTable('import', 'any_table', 4, 4, kWasmAnyRef);
7373
let imported_func_table =

‎test/inspector/debugger/wasm-gc-multi-module.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ async function instantiateWasm(module_name, add_extra_types) {
101101
let array_type;
102102
if (add_extra_types) {
103103
builder.startRecGroup();
104-
array_type = builder.addArray(kWasmI32, true);
104+
array_type = builder.addArray(kWasmI32);
105105
builder.endRecGroup();
106106
}
107107
builder.startRecGroup();

‎test/js-perf-test/TurboFan/wasm-inlining-loop-array.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ if (use_module_builder) {
2929

3030
if (use_module_builder) {
3131
let builder = new WasmModuleBuilder();
32-
let backingStore = builder.addArray(kWasmI32, true);
32+
let backingStore = builder.addArray(kWasmI32);
3333
let arrayStruct = builder.addStruct([
3434
makeField(kWasmI32 /*length*/, true),
3535
makeField(wasmRefType(backingStore), true)

‎test/message/wasm-inlining-into-js.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ function testOptimized(run, fctToOptimize) {
2222
function createWasmModule(moduleName) {
2323
let builder = new WasmModuleBuilder();
2424
builder.setName(moduleName);
25-
let array = builder.addArray(kWasmI32, true);
25+
let array = builder.addArray(kWasmI32);
2626

2727
builder.addFunction('createArray', makeSig([kWasmI32], [kWasmExternRef]))
2828
.addBody([

‎test/message/wasm-recognize-imports.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,10 @@ d8.file.execute('test/mjsunit/wasm/wasm-module-builder.js');
104104

105105
let builder = new WasmModuleBuilder();
106106
builder.startRecGroup();
107-
let kArrayI16 = builder.addArray(kWasmI16, true, kNoSuperType, true);
107+
let kArrayI16 = builder.addArray(kWasmI16, {final: true});
108108
builder.endRecGroup();
109109
builder.startRecGroup();
110-
let kArrayI8 = builder.addArray(kWasmI8, true, kNoSuperType, true);
110+
let kArrayI8 = builder.addArray(kWasmI8, {final: true});
111111
builder.endRecGroup();
112112
let a16ref = wasmRefNullType(kArrayI16);
113113
let a8ref = wasmRefNullType(kArrayI8);

‎test/mjsunit/regress/regress-447206453.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
d8.file.execute("test/mjsunit/wasm/wasm-module-builder.js");
88

99
var builder = new WasmModuleBuilder();
10-
let array_type_index = builder.addArray(kWasmI32, true);
10+
let array_type_index = builder.addArray(kWasmI32);
1111

1212
builder.addFunction('createArray', makeSig([kWasmI32], [kWasmExternRef]))
1313
.addBody([

‎test/mjsunit/regress/wasm/regress-1236958.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ d8.file.execute('test/mjsunit/wasm/wasm-module-builder.js');
66

77
var builder = new WasmModuleBuilder();
88

9-
let array = builder.addArray(kWasmI64, true);
9+
let array = builder.addArray(kWasmI64);
1010

1111
builder.addFunction('test', kSig_v_v)
1212
.addBody([kExprLoop, kWasmVoid,

‎test/mjsunit/regress/wasm/regress-1237024.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ d8.file.execute('test/mjsunit/wasm/wasm-module-builder.js');
66

77
var builder = new WasmModuleBuilder();
88

9-
let array_index = builder.addArray(kWasmS128, true);
9+
let array_index = builder.addArray(kWasmS128);
1010

1111
builder.addFunction("main", kSig_i_i)
1212
.addBody([

0 commit comments

Comments
 (0)