Skip to content

bug(isMobilePhone): update regex for de-DE#1391

Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom
heanzyzabala:bugfix/isMobilePhone-update-de_De-regex
Jul 25, 2020
Merged

bug(isMobilePhone): update regex for de-DE#1391
profnandaa merged 1 commit intovalidatorjs:masterfrom
heanzyzabala:bugfix/isMobilePhone-update-de_De-regex

Conversation

@heanzyzabala
Copy link
Contributor

@heanzyzabala heanzyzabala commented Jul 25, 2020 •
edited
Loading

I loosened the regex for de-DE to support the unhandled value given in the issue.
The changes prompts some of the invalid values to pass, but I added additional tests to backup the change.

Checklist

  • [] PR contains only changes related; no stray files, etc.
  • [] README updated (where applicable)
  • [] Tests written (where applicable)

@heanzyzabala heanzyzabala mentioned this pull request Jul 25, 2020
Closed
profnandaa
profnandaa approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contrib! 🎉

@profnandaa profnandaa merged commit f67a57f into validatorjs:master Jul 25, 2020
@profnandaa profnandaa mentioned this pull request Sep 18, 2020
Merged
@Burnett01 Burnett01 mentioned this pull request May 24, 2021
Closed
@thomaschaaf
Copy link
Contributor

thomaschaaf commented Nov 15, 2021

Hello! This PR is incorrect.. as you can see here +4930 is landline..

https://libphonenumber.appspot.com/phonenumberparser?number=%2B4930405044550

https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering mobile phone numbers must start with a 15, 16 or 17

thomaschaaf added a commit to thomaschaaf/validator.js that referenced this pull request Nov 15, 2021
@thomaschaaf
revert validatorjs#1391
bbddc7b
@thomaschaaf thomaschaaf mentioned this pull request Nov 15, 2021
Merged
profnandaa pushed a commit that referenced this pull request Nov 17, 2021
@thomaschaaf
fix(isMobilePhone): update de-DE regex to exclude landline numbers (#…
9c12b4c 
…1868)

* revert #1391

* remove invalid number blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heanzyzabala @thomaschaaf @profnandaa