Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 95 95
Lines 1268 1270 +2
=======================================
+ Hits 1267 1269 +2
Misses 1 1
Continue to review full report at Codecov.
|
Member
Author
|
@profnandaa check this only after my previous pr |
ezkemboi
reviewed
Sep 30, 2020
| .nyc_output | ||
| package-lock.json | ||
| yarn.lock | ||
| es |
Member
There was a problem hiding this comment.
What is your opinion in ignoring the generated files @profnandaa and @tux-tn?
ezkemboi
reviewed
Sep 30, 2020
| **isDivisibleBy(str, number)** | check if the string is a number that's divisible by another. | ||
| **isEAN(str)** | check if the string is an EAN (European Article Number). | ||
| **isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. | ||
| **isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '' }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` recieves a string,then the validator will reject emails that include any of the characters in the string, in the name part. |
ezkemboi
requested changes
Sep 30, 2020
|
|
||
| function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; } | ||
|
|
||
| import merge from './util/merge'; |
Member
There was a problem hiding this comment.
There are many changes here that are the same as in #1449.
Please remove them
Member
Author
|
i am closing this as and will do another pr |
Member
|
Remember to link it to the issue once done. |
profnandaa
added a commit
that referenced
this pull request
Nov 24, 2020
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450
profnandaa
added a commit
that referenced
this pull request
Nov 24, 2020
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450
profnandaa
added a commit
that referenced
this pull request
Nov 24, 2020
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450
profnandaa
added a commit
that referenced
this pull request
Nov 24, 2020
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450
profnandaa
added a commit
that referenced
this pull request
Nov 24, 2020
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added few folders that contains generated code. Thus the git status does not get messy
Checklist