Codecov Report

Merging #1455 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1275     1276    +1     
=======================================
+ Hits         1274     1275    +1     
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7916dfd...a83805e. Read the comment docs.

Thanks for your contribution! Please rebase your branch with master so as to remove the unrelated changes, then we can review.

I have removed all unnecessary changes, please tell me if i do something wrong here.

Im pretty sure that there are nothing to be updated in the readme file regarding these changes as its already well-documented there (in the readme) @profnandaa

Edit: I've checked all the boxes so its all clear

@fakhrip -- my bad, thought it was a new locale.
However, see what you need to fix in L94-103 since it will override what you have added.

@fakhrip -- my bad, thought it was a new locale.
However, see what you need to fix in L94-103 since it will override what you have added.

Im sorry but i didnt get it, in which file should i see this ?

That's alpha.js; let me know if there's anything that should be done.

Can we just add this to line 121 in alpha.js to kind of re-override it ?
alpha['fa-IR'] = alpha['fa-IR'];

Ok, that works, you can drop in a comment before that.

Done, if there are anything i should do, please tell me 🙏

Sure, thank you so much for being good as this is my first legit PR 😃

Welcome buddy, looking forward to seeing more from you :)

@profnandaa @fakhrip i don't understand the purpose of the change in L124 😅

It was overriden by L101 @tux-tn ,
So there i have to "reoverride" it to set the fa-ir to fa-ir (it may sound confusing though, haha)

I still don't get it, since alpha array has already been mutated alpha['fa-ir'] received alpha['fa'] content, how is re-overriding it is supposed to bring back the old content?
Logging content before and after the line shows the same value

export const farsiLocales = [
  'IR', 'AF',
];

for (let locale, i = 0; i < farsiLocales.length; i++) {
  locale = `fa-${farsiLocales[i]}`;
  alpha[locale] = alpha.fa;  // This line changes alpha[fa-IR] content to alpha.fa
  alphanumeric[locale] = alphanumeric.fa;
  decimal[locale] = decimal.fa;
}

And because that the content of alpha.fa and alpha[fa-IR] is different (look below)

'fa-IR': /^[ابپتثجچحخدذرزژسشصضطظعغفقکگلمنوهی]+$/i,
fa: /^['0-9آاءأؤئبپتثجچحخدذرزژسشصضطظعغفقکگلمنوهةی۱۲۳۴۵۶۷۸۹۰']+$/i,

It will then be needed to re-override the alpha[fa-IR] that was changed to alpha.fa, to then become alpha[fa-IR] itself

alpha[locale] = alpha.fa; alpha[fa-IR] has been mutated and contains content of alpha.fa here, right?
Since `alpha[fa_IR] has already been mutated where is stored the old value that you need to reassign?

Oh wait, i just realized that i was wrong XD, i'm very sorry dude, now i feel like really stupid...

Do you think i need to fix this in another PR as this one already got merged, or what should i do best ?

@fakhrip actually i'm asking the question because i'm working on a PR to update dependencies (including eslint who keeps screaming about that line) i fixed it in my branch and i'll probably create a PR by the end of the week.

@fakhrip actually i'm asking the question because i'm working on a PR to update dependencies (including eslint who keeps screaming about that line) i fixed it in my branch and i'll probably create a PR by the end of the week.

Sure, you're statement is all good, it was my fault, i'm sorry @tux-tn

@fakhrip no problem my friend, thank you for taking the time to answer my questions. It's not a big deal

thanks for the due diligence on this @tux-tn