Skip to content

Malaysian Passport validation#1501

Closed
stranger26 wants to merge 2 commits intovalidatorjs:masterfrom
stranger26:MY-Passport
Closed

Malaysian Passport validation#1501
stranger26 wants to merge 2 commits intovalidatorjs:masterfrom
stranger26:MY-Passport

Conversation

@stranger26
Copy link
Contributor

@stranger26 stranger26 commented Oct 26, 2020

Added Malaysian Passport validation

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 26, 2020 •
edited
Loading

Codecov Report

Merging #1501 (4ab37f5) into master (bab507a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1501   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1277     1277           
=======================================
  Hits         1276     1276           
  Misses          1        1
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab507a...5d315ab. Read the comment docs.

tux-tn
tux-tn requested changes Nov 20, 2020
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you please discard auto-generated files: index.js, validation.js and validator.min.js since they contain unrelated changes

profnandaa
profnandaa previously approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉 Pls fix the merge conflict and we should be good to go.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Nov 29, 2020
ezkemboi
ezkemboi requested changes Dec 13, 2020
View reviewed changes
@profnandaa
Copy link
Member

profnandaa commented Dec 17, 2020

@stranger26 -- some more merge conflicts...

@stranger26
Copy link
Contributor Author

stranger26 commented Dec 17, 2020 •
edited
Loading

Will re-open the pull request help? I think the conflict came in the second commit, or will squashing my commits do the job?

@profnandaa
Copy link
Member

profnandaa commented Dec 17, 2020

Sorry, it was caused by another merge. We are working on something to minimize these kind of conflicts; soonest.

@stranger26 stranger26 mentioned this pull request Jan 6, 2021
Merged
3 tasks
@stranger26
Copy link
Contributor Author

stranger26 commented Jan 6, 2021

@profnandaa @ezkemboi reopened in #1574

@stranger26 stranger26 closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tux-tn tux-tn tux-tn requested changes

@ezkemboi ezkemboi ezkemboi approved these changes

@profnandaa profnandaa profnandaa left review comments

Assignees

No one assigned

Labels

mc-to-land Just merge-conflict standing between the PR and landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stranger26 @profnandaa @tux-tn @ezkemboi