Skip to content

feature: Oman mobile phone validation added to isMobilePhone#1506

Merged
profnandaa merged 3 commits intovalidatorjs:masterfrom
dev-sna:feat/Oman_Mobile_Number_Validation
Dec 1, 2020
Merged

feature: Oman mobile phone validation added to isMobilePhone#1506
profnandaa merged 3 commits intovalidatorjs:masterfrom
dev-sna:feat/Oman_Mobile_Number_Validation

Conversation

@dev-sna
Copy link
Contributor

@dev-sna dev-sna commented Oct 27, 2020 •
edited
Loading

This pull request adds support for validation of Oman's mobile phone numbers to isMobilePhone validator.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@dev-sna dev-sna closed this Oct 27, 2020
@dev-sna dev-sna reopened this Oct 27, 2020
@dev-sna dev-sna mentioned this pull request Oct 27, 2020
Closed
@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #1506 (963d0a1) into master (0b0b4e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1506   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99        99           
  Lines         1773      1773           
=========================================
  Hits          1773      1773
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0b4e9...34bd8bc. Read the comment docs.

profnandaa
profnandaa approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa
Copy link
Member

profnandaa commented Nov 19, 2020

Pls fix the merge conflicts.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Nov 19, 2020
@dev-sna
Copy link
Contributor Author

dev-sna commented Nov 30, 2020

@profnandaa conflicts resolved.

profnandaa
profnandaa approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 9dc4ed3 into validatorjs:master Dec 1, 2020
@abdulmoizeng
Copy link

abdulmoizeng commented Dec 2, 2020 •
edited
Loading

Much needed PR, Thanks @dev-sna 👍

@nasirhm
Copy link

nasirhm commented Dec 2, 2020

Awesome addition to the library @dev-sna 👍

@profnandaa profnandaa removed the 🧹 needs-update For PRs that need to be updated before landing label Dec 3, 2020
@abdulmoizeng
Copy link

abdulmoizeng commented Mar 17, 2021

Thanks for creating this, was much needed @dev-sna

@abdulmoizeng
Copy link

abdulmoizeng commented Mar 17, 2021

@profnandaa By when is the team releasing this?

@tux-tn
Copy link
Member

tux-tn commented Mar 17, 2021

@abdulmoizeng a new release is planned before the end of this month

@profnandaa profnandaa mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees

No one assigned

Labels

🎉 first-pr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dev-sna @profnandaa @abdulmoizeng @nasirhm @tux-tn