Skip to content

feat: replace insensitive terms#1522

Closed
fedeci wants to merge 9 commits intovalidatorjs:masterfrom
fedeci:replace-insensitive-terms
Closed

feat: replace insensitive terms#1522
fedeci wants to merge 9 commits intovalidatorjs:masterfrom
fedeci:replace-insensitive-terms

Conversation

@fedeci
Copy link
Contributor

@fedeci fedeci commented Nov 16, 2020

This PR replaces all those terms considered insensitive and racist.

Nothing of what is contained in this pull request is a breaking change.

Particularly it tackles:

  • deprecation of blacklist and whitelist sanitizers
  • deprecation of isWhitelisted validator
  • deprecation of some old isURL and isEmail options
  • changing of variable names

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Nov 16, 2020 •
edited
Loading

Codecov Report

Merging #1522 (9e4630e) into master (a19ebff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1522   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1286     1289    +3     
=======================================
+ Hits         1285     1288    +3     
  Misses          1        1
Impacted Files Coverage Δ
src/lib/allowlist.js 100.00% <ø> (ø)
src/lib/denylist.js 100.00% <ø> (ø)
src/lib/isAllowlisted.js 100.00% <ø> (ø)
src/index.js 100.00% <100.00%> (ø)
src/lib/isDecimal.js 100.00% <100.00%> (ø)
src/lib/isEmail.js 100.00% <100.00%> (ø)
src/lib/isURL.js 100.00% <100.00%> (ø)
src/lib/stripLow.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19ebff...9e4630e. Read the comment docs.

@profnandaa
Copy link
Member

profnandaa commented Nov 17, 2020

Respectively I have to turn this down. Personally I have very strong view on this issues -- changing names is such a cosmetic approach to solving this issue. But yes, black lives matter.

/cc. @chriso

@profnandaa profnandaa closed this Nov 17, 2020
@profnandaa
Copy link
Member

profnandaa commented Nov 17, 2020

However, please feel free to contribute this project on the other open issues, welcome! Thanks for the PR.

@fedeci
Copy link
Contributor Author

fedeci commented Nov 17, 2020

Respectively I have to turn this down. Personally I have very strong view on this issues -- changing names is such a cosmetic approach to solving this issue. But yes, black lives matter.

/cc. @chriso

Sure, changing names is just a cosmetic approach, but because the most of major companies like Apple and Microsoft and even Babel are deprecating old names, wouldn't it be a good idea to follow this new "standard"?

@fedeci fedeci deleted the replace-insensitive-terms branch November 30, 2020 14:36
@tux-tn tux-tn mentioned this pull request Apr 16, 2021
Merged
3 tasks
@WikiRik WikiRik mentioned this pull request Jul 19, 2022
Open
@sklawren sklawren mentioned this pull request Jul 20, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fedeci @profnandaa