Closed
Conversation
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450
Member
Author
Member
|
That will prevent many conflicts/ issues but why not removing index.js too since we are removing lib |
Member
Author
|
Good catch, sure, will remove it too.
On Tue, Nov 24, 2020 at 12:34 PM Sarhan Aissi ***@***.***> wrote:
That will prevent many conflicts/ issues but why not removing index.js too
since we are removing lib
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1526 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB7ZEPJEMFOGTWH55EZNBTSRN4ZHANCNFSM4UAJVYKA>
.
--
Sent from a tiny device while on the move.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are removing validator.js and validator.min.js since they are among
the top files that cause unnecessary conflicts, yet they are dependent
on the build system.
this is a follow up of #1450