Multiple fixes related to alpha, tests and build#1528
Merged
profnandaa merged 10 commits intovalidatorjs:masterfrom Nov 29, 2020
Merged
Multiple fixes related to alpha, tests and build#1528profnandaa merged 10 commits intovalidatorjs:masterfrom
profnandaa merged 10 commits intovalidatorjs:masterfrom
Conversation
Related: #15101
Codecov Report
@@ Coverage Diff @@
## master #1528 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 98 98
Lines 1763 1765 +2
=========================================
+ Hits 1763 1765 +2
Continue to review full report at Codecov.
|
profnandaa
approved these changes
Nov 29, 2020
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib! 🎉
| "build:node": "babel src -d .", | ||
| "build": "npm run build:browser && npm run build:node && npm run build:es", | ||
| "pretest": "npm run lint && npm run build", | ||
| "pretest": "npm run build && npm run lint", |
Member
There was a problem hiding this comment.
I think this is one of the things making my previous builds to fail, I'll retry the PR I'd reverted.
This was referenced Dec 6, 2020
Merged
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index.jsas discussed in chore: update gitignore #1526 and fixed pipeline to prevent running eslint before buildingfr-CAlocale as discussed in feat: Add fr-CA locale #1511 (based on @purell work )fa-IRlocale as discussed in fix(isAlpha): fix ح character validation in fa-IR language code (#1400) #1455isStrongPasswordwith default options to make code coverage happy again (100%) .sudokey in travis config https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migrationChecklist