fix: return index.js due to strong dep [don't merge yet]#1540
fix: return index.js due to strong dep [don't merge yet]#1540profnandaa wants to merge 1 commit intomasterfrom
Conversation
index.js has a strong dep for webpack, etc builds. Before publishing, you should run > [email protected] pretest /home/nandaa/dev/opensource/validator.js > npm run build && npm run lint > [email protected] build /home/nandaa/dev/opensource/validator.js > npm run build:browser && npm run build:node && npm run build:es > [email protected] build:browser /home/nandaa/dev/opensource/validator.js > node --require @babel/register build-browser && npm run minify > [email protected] minify /home/nandaa/dev/opensource/validator.js > uglifyjs validator.js -o validator.min.js --compress --mangle --comments /Copyright/ > [email protected] build:node /home/nandaa/dev/opensource/validator.js > babel src -d . Successfully compiled 99 files with Babel (2323ms). > [email protected] build:es /home/nandaa/dev/opensource/validator.js > babel src -d es --env-name=es Successfully compiled 99 files with Babel (1600ms). > [email protected] lint /home/nandaa/dev/opensource/validator.js > eslint src test > [email protected] test /home/nandaa/dev/opensource/validator.js > nyc mocha --require @babel/register --reporter dot ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․ ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․ ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․ ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․ 207 passing (180ms) =============================== Coverage summary =============================== Statements : 100% ( 1918/1918 ) Branches : 100% ( 1112/1112 ) Functions : 100% ( 194/194 ) Lines : 100% ( 1773/1773 ) ================================================================================ again to generate all the files but I forgot to do this in 13.5.0 which broke people. For this case, I'd prefer that we restore at least autogenerated file; for now.
profnandaa
changed the title
profnandaa
added
blocked
|
Let me think and research the best way to do automation. |
|
I suggest to automate this step using github actions: |
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
If you agree with the idea of using github actions, i suggest also to move all our CI workflow to github-actions for consistence.
|
@tux-tn -- good idea, let's go with that. I'll check out the docs, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1540 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 99 99
Lines 1773 1773
=========================================
Hits 1773 1773 Continue to review full report at Codecov.
|
|
@profnandaa can i take care of it? |
|
Yes sir, please do. I would like us to start off with a staging NPM package which I'm going to create |
|
/cc. @chriso |
|
@tux-tn -- checkout the guide here while at it - https://github.com/validatorjs/validator.js/wiki/Maintainers-Guide |
|
closing coz #1553 |
3 participants
index.js has a strong dep for webpack, etc builds. Before publishing, you should run
again to generate all the files but I forgot to do this in 13.5.0 which broke people. For this case, I'd prefer that we restore at least auto-generated file; for now.
However -- we need to find a more long-term solution that helps our publishing pipeline predictability. For my case, I'd skipped a step to auto-generate files. I'd done this one machine but was firewalled, so had to move machines and on the later, I forgot step before publishing.
@ezkemboi @tux-tn -- let's think about the best soln here...