Codecov Report

Merging #1568 (941944d) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1568   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1796      1796           
=========================================
  Hits          1796      1796           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...941944d. Read the comment docs.

is there a problem with PR?

Your PR is probably fine, they are waiting for #1553 before they review any other PR.

thanks a lot. its my first try to contribute on open source project i will continue to check issues👍🏻👍🏻

thanks a lot. its my first try to contribute on open source project i will continue to check issues👍🏻👍🏻

It's great work for a first time contribution 👏 👏 👏 . Don't hesitate to pick another issue or add a new locale to an existing validator (We have many missing locales in isMobilePhone , isLicensePlate , isTaxID and other validators) and if you have questions or need some help feel free to ask in the gitter chatroom .

Hello @bakyazi
It looks like #1594 have fixed the issue your PR is trying to address, closing since duplicate but feel free to try to fix other issues.