fix: update isMobilePhone validation for en-SG#1573
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Apr 13, 2021
liliwei25:update-is-mobile-phone
Merged
fix: update isMobilePhone validation for en-SG#1573profnandaa merged 1 commit intovalidatorjs:masterfrom liliwei25:update-is-mobile-phone
profnandaa merged 1 commit intovalidatorjs:masterfrom
liliwei25:update-is-mobile-phone
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1796 1796
=========================================
Hits 1796 1796
Continue to review full report at Codecov.
|
tux-tn
approved these changes
Mar 8, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
LGTM! Thank you @liliwei25 and congrats for your first PR 🎉
tux-tn
added
needs-more-review
🎉 first-pr
ready-to-land
profnandaa
approved these changes
Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update isMobilePhone validation for en-SG to include numbers starting with
3Checklist