Added Libya Passport and Identity Number Validation#1583
Merged
profnandaa merged 3 commits intovalidatorjs:masterfrom Feb 28, 2021
Merged
Added Libya Passport and Identity Number Validation#1583profnandaa merged 3 commits intovalidatorjs:masterfrom
profnandaa merged 3 commits intovalidatorjs:masterfrom
Conversation
asghaier76
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1583 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1796 1798 +2
=========================================
+ Hits 1796 1798 +2
Continue to review full report at Codecov.
|
tux-tn
previously approved these changes
Jan 29, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Congrats for your first contrib 🎉
LGTM
tux-tn
added
needs-more-review
🎉 new contributor
🎉 first-pr
and removed
🎉 new contributor
labels
tux-tn
approved these changes
Feb 26, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Deleted ignored validator.min.js and validator.js to fix conflict. We should be able to merge. Thank you again for your contribution
profnandaa
approved these changes
Feb 28, 2021
Member
|
Thanks for your PR @asghaier76 and welcome to the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{{ Adding validation for Libyan Passport Number and Libyan Identity Number }}
Checklist